Skip to content

Conversation

@bewing
Copy link

@bewing bewing commented Jan 2, 2026

sFlow text fields must account for padding bytes when reading the buffer.

ref: https://datatracker.ietf.org/doc/html/rfc4506#section-3
ref: https://datatracker.ietf.org/doc/html/rfc4506#section-4.11

@bewing bewing changed the title fix(sflow) XDR must be 4-byte-aligned fix(sflow): XDR must be 4-byte-aligned Jan 5, 2026
@lspgn
Copy link
Member

lspgn commented Jan 7, 2026

Thank you! I think this may be integrated into #480 but will have a look

@bewing
Copy link
Author

bewing commented Jan 7, 2026

Thank you! I think this may be integrated into #480 but will have a look

That does appear to be a fix - apologies for not noticing it in the queue.

Curious if the multi-modulus from #480 or the negative & 3 is more readable.

@bewing bewing closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants