utils: make fallback realpath safe#53
Open
cyberman wants to merge 1 commit intonetsurf-browser:masterfrom
Open
utils: make fallback realpath safe#53cyberman wants to merge 1 commit intonetsurf-browser:masterfrom
cyberman wants to merge 1 commit intonetsurf-browser:masterfrom
Conversation
cyberman
commented
Mar 1, 2026
cyberman
commented
- The #ifndef HAVE_REALPATH fallback used an unbounded strcpy() into a caller-provided buffer.
- Make the fallback safe by supporting only the allocating form (realpath(path, NULL)), and failing with errno for the non-NULL buffer form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.