Method for getting specific definition#192
Open
Spamercz wants to merge 10 commits intonette:masterfrom
Open
Conversation
… service (nette#39) for BC compatibility, 'class' will override 'factory'
- getServiceDefinition - getAccessorDefinition - getFactoryDefinition - getLocatorDefinition - getImportedDefinition
- in places where are specifically used methods from ServiceDefinition
- getServiceDefinition - getAccessorDefinition - getFactoryDefinition - getLocatorDefinition - getImportedDefinition
Spamercz
force-pushed
the
get-specific-definition
branch
from
1f50a37 to
62c74fa
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
2d173ea to
f6cd1c6
Compare
dg
force-pushed
the
master
branch
12 times, most recently
from
90c07f8 to
dd3170c
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
b780eca to
7ae47da
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
577360f to
da70799
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
807c468 to
9e6be87
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
5ddfaf1 to
d41e22c
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
38608a6 to
766e818
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
1c50bf6 to
8eaccb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are specific addDefinition methods for each type of Definition but no getDefinition for getting specific definitions. You can only use
\Nette\DI\ContainerBuilder::getDefinitionwith abstract return type\Nette\DI\Definitions\Definitionso in your extensions you have to every time assert that you are getting right type of Definition so you can use Definition specific methods.So I added specific Getters like
\Nette\DI\ContainerBuilder::getServiceDefinition.