Skip to content

Commit 6241e4d

Browse files
committed
Helpers::isNamespace() -> isNamespaceIdentifier()
1 parent d0fa50b commit 6241e4d

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

src/PhpGenerator/Helpers.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ public static function isIdentifier($value): bool
229229
}
230230

231231

232-
public static function isNamespace($value): bool
232+
public static function isNamespaceIdentifier($value): bool
233233
{
234234
return is_string($value) && preg_match('#^' . Helpers::PHP_IDENT . '(\\\\' . Helpers::PHP_IDENT . ')*\z#', $value);
235235
}

src/PhpGenerator/PhpNamespace.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ final class PhpNamespace
4646

4747
public function __construct(string $name)
4848
{
49-
if ($name !== '' && !Helpers::isNamespace($name)) {
49+
if ($name !== '' && !Helpers::isNamespaceIdentifier($name)) {
5050
throw new Nette\InvalidArgumentException("Value '$name' is not valid name.");
5151
}
5252
$this->name = $name;

tests/PhpGenerator/Helpers.isNamespace.phpt

Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
use Nette\PhpGenerator\Helpers;
6+
use Tester\Assert;
7+
8+
9+
require __DIR__ . '/../bootstrap.php';
10+
11+
12+
Assert::true(Helpers::isNamespaceIdentifier('Item'));
13+
Assert::true(Helpers::isNamespaceIdentifier("\x7F"));
14+
Assert::true(Helpers::isNamespaceIdentifier("\x7F\\\x7F"));
15+
Assert::false(Helpers::isNamespaceIdentifier('0Item'));
16+
Assert::true(Helpers::isNamespaceIdentifier('Item\Item'));
17+
Assert::false(Helpers::isNamespaceIdentifier('Item\\\\Item'));
18+
Assert::false(Helpers::isNamespaceIdentifier('\\Item'));
19+
Assert::false(Helpers::isNamespaceIdentifier('Item\\'));

0 commit comments

Comments
 (0)