Parameter::setDefaultValue() automatically sets setOptional(), setOptional is deprecated (BC break)

Author: dg

src/PhpGenerator/Factory.php

@@ -107,7 +107,6 @@ public function fromParameterReflection(\ReflectionParameter $from)
 		$param->setTypeHint($from->hasType() ? (string) $from->getType() : NULL);
 		$param->setNullable($from->hasType() && $from->getType()->allowsNull());
 		if ($from->isDefaultValueAvailable()) {
-			$param->setOptional(TRUE);
 			$param->setDefaultValue($from->isDefaultValueConstant()
 				? new PhpLiteral($from->getDefaultValueConstantName())
 				: $from->getDefaultValue());

src/PhpGenerator/Parameter.php

@@ -77,6 +77,7 @@ public function getTypeHint()
 
 
 	/**
+	 * @deprecated  just use setDefaultValue()
 	 * @param  bool
 	 * @return static
 	 */
@@ -93,6 +94,7 @@ public function setOptional($state = TRUE)
 	 */
 	public function isOptional()
 	{
+		trigger_error(__METHOD__ . '() is deprecated, use hasDefaultValue()', E_USER_DEPRECATED);
 		return $this->hasDefaultValue;
 	}
 
@@ -123,6 +125,7 @@ public function isNullable()
 	public function setDefaultValue($val)
 	{
 		$this->defaultValue = $val;
+		$this->hasDefaultValue = TRUE;
 		return $this;
 	}
 

src/PhpGenerator/Traits/FunctionLike.php

@@ -107,7 +107,7 @@ public function addParameter($name, $defaultValue = NULL)
 	{
 		$param = new Parameter($name);
 		if (func_num_args() > 1) {
-			$param->setOptional(TRUE)->setDefaultValue($defaultValue);
+			$param->setDefaultValue($defaultValue);
 		}
 		return $this->parameters[$name] = $param;
 	}