Add option to wait for a ready message before running h3spec test#14
Merged
Add option to wait for a ready message before running h3spec test#14
Conversation
Motivation: The millisecond delay might not be sufficiently reliable in some environments, and can also be wasteful in how long builds will wait to ensure reliable execution. Modification: Make it possible for the test to snoop on the System.out stream and look for a readiness message instead, as the signal to start running the test. Result: This should produce more reliable build executions.
Member
Author
|
Thanks, I'll merge this and then give the resulting SNAPSHOT build a try in the branch. |
chrisvest
added a commit
to chrisvest/netty
that referenced
this pull request
May 20, 2025
Use netty/netty-incubator-h3spec-maven-plugin#14 to ensure that the test server is started before running the h3spec tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The millisecond delay might not be sufficiently reliable in some environments, and can also be wasteful in how long builds will wait to ensure reliable execution.
Modification:
Make it possible for the test to snoop on the System.out stream and look for a readiness message instead, as the signal to start running the test.
Result:
This should produce more reliable build executions.