build: fix for broken MSVC and Open Watcom makefiles#103
build: fix for broken MSVC and Open Watcom makefiles#103jmalak wants to merge 0 commit intonetwide-assembler:masterfrom
Conversation
|
As of 3.00rc19, the code seems to work, but I will look at this for 3.01 to see if it can be done better. |
|
Team was busy on getting 3.00 release ready. And the msvc building system got a huge improvement. |
a88744a to
ee34545
Compare
|
Hi, this seems to fail the tests you have added :) Also, I don't know much about github CI/CD, but if you could please check to see if conflicts with the one added on the nasm-3.00.xx branch (which is the correct branch for this.) If wmake needs %make, then $(MAKE) should be set appropriately, instead of making it a wmake-specific rule. As many of the rules should be put into the generated sections (#-- --#) so that they are explicitly kept in sync. Since it looks like you are re-introducing the warnings rules for the auxiliary Makefiles it does have potential issues. I also wonder if it would be better to make OpenWatcom work with GNU make/owcc (owcc was broken last time I tried it) and ideally configure instead of WMAKE. Alternatively, config/watcom.h almost certainly needs updating... |
|
FYI - I'm going to be disaggregating the warnings from the source code. It "seemed like a good idea" but has turned out to be a nightmare from a dependency point of view. |
98b6058 to
8ae1b63
Compare
0318703 to
c4adb69
Compare
|
No problem, I can do it for you if you have a new version then send me note and I will check and fix if needed. |
fix recursive call to make for MSVC and Open Watcom
do make files more consistent