Skip to content

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Security

  • Patched transitive vulnerabilities by pinning dependencies via overrides:
    • Forced tmp to >=0.2.4 (resolves CVE-2025-54798 reported via @lhci/cli).
    • Forced cookie to ^1.0.0 (used by @sveltejs/kit and @lhci/cli).

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked for existing Pull Requests for the same update/change.
  • My code follows the project’s coding style.
  • My code has been linted locally before submission.
  • All new and existing tests pass.

 

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, if applicable. (Optional, especially for new contributors)

Pull requests are part of a collaborative process — we welcome contributions and review each one carefully. For all but the smallest changes, you can expect maintainers to request improvements or clarifications.

Please check back after opening your PR and be responsive to feedback so we can get your contribution merged quickly.

Thanks for helping improve Network Pro Strategies!

@netlify
Copy link

netlify bot commented Sep 18, 2025

Deploy Preview for networkpro-web ready!

Name Link
🔨 Latest commit ab3b455
🔍 Latest deploy log https://app.netlify.com/projects/networkpro-web/deploys/68cbce3c5a53690008ea6a70
😎 Deploy Preview https://deploy-preview-126--networkpro-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging pending successful test completion.

@github-actions
Copy link

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.92)
  • Largest Contentful Paint (score: 0.3)
  • Speed Index (score: 0.93)
  • Time to Interactive (score: 0.78)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Serve static assets with an efficient cache policy (score: 0.5)
  • Reduce unused CSS (score: 0)
  • Reduce unused JavaScript (score: 0)
  • Avoid serving legacy JavaScript to modern browsers (score: 0.5)
  • Use efficient cache lifetimes (score: 0)
  • Optimize DOM size (score: 0)
  • Legacy JavaScript (score: 0.5)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

@SunDevil311 SunDevil311 merged commit 728253c into master Sep 18, 2025
12 checks passed
@SunDevil311 SunDevil311 deleted the security/update-tmp branch September 18, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants