Skip to content

Update workflows and correct .lighthouserc.mjs#50

Merged
SunDevil311 merged 19 commits intomasterfrom
feature/fix-workflow
May 20, 2025
Merged

Update workflows and correct .lighthouserc.mjs#50
SunDevil311 merged 19 commits intomasterfrom
feature/fix-workflow

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Updated workflows to reflect recent just with Node setup and caching. Also corrected .lighthouserc.mjs so that the workflow should properly upload the file.

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked to make sure there aren't existing Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My code has been linted locally prior to submission.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Where applicable, I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project.

With all but the simplest changes, you can and should expect that the maintainers of the project will request changes to your code.

Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thank you!

@netlify
Copy link

netlify bot commented May 20, 2025

Deploy Preview for networkpro-web ready!

Name Link
🔨 Latest commit 98e2064
🔍 Latest deploy log https://app.netlify.com/projects/networkpro-web/deploys/682c5892936bfe0008566a86
😎 Deploy Preview https://deploy-preview-50--networkpro-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SunDevil311 SunDevil311 self-assigned this May 20, 2025
Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files good to go. Merging.

@SunDevil311 SunDevil311 merged commit 997b536 into master May 20, 2025
11 checks passed
@SunDevil311 SunDevil311 deleted the feature/fix-workflow branch May 20, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant