Skip to content

Added _redirects file, updated dependencies, pinned svelte version du…#51

Merged
SunDevil311 merged 6 commits intomasterfrom
feature/fix-redirects
May 21, 2025
Merged

Added _redirects file, updated dependencies, pinned svelte version du…#51
SunDevil311 merged 6 commits intomasterfrom
feature/fix-redirects

Conversation

@SunDevil311
Copy link
Member

@SunDevil311 SunDevil311 commented May 20, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added _redirects file, updated dependencies, pinned svelte version due to circular reference in versions >5.31.1.

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked to make sure there aren't existing Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My code has been linted locally prior to submission.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Where applicable, I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project.

With all but the simplest changes, you can and should expect that the maintainers of the project will request changes to your code.

Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thank you!

@netlify
Copy link

netlify bot commented May 20, 2025

Deploy Preview for networkpro-web ready!

Name Link
🔨 Latest commit 90dadf3
🔍 Latest deploy log https://app.netlify.com/projects/networkpro-web/deploys/682d97b65a4edf00089b2225
😎 Deploy Preview https://deploy-preview-51--networkpro-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SunDevil311 SunDevil311 self-assigned this May 20, 2025
…. Updated preferred node version in .node-version and .nvmrc to match dev environment. Added JSdoc annotation, enabled jsdoc/require-jsdoc warnings. Added jsdoc check to workflow.
…nt changes to workflows, restructured scripts section of package.json.
…w handle E2E tests and Vitest will handle unit tests.
Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging.

@SunDevil311 SunDevil311 merged commit 0f56bda into master May 21, 2025
11 checks passed
@SunDevil311 SunDevil311 deleted the feature/fix-redirects branch May 21, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant