Remove Docassemble core dependency from install_requires#13
Open
nonprofittechy wants to merge 1 commit intonetworkninja:mainfrom
Open
Remove Docassemble core dependency from install_requires#13nonprofittechy wants to merge 1 commit intonetworkninja:mainfrom
nonprofittechy wants to merge 1 commit intonetworkninja:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
docassemble.webapp>=1.4.54packaging dependency frominstall_requires.Why
This package is being installed into Docassemble servers that already provide the Docassemble core stack. Keeping a broad
docassemble.webapp>=...dependency allowspipto resolve Docassemble core packages from PyPI during managed package installs.In a live Docassemble-managed install test, that dependency caused the resolver to walk into older core releases from PyPI, including
docassemble.base==1.7.0anddocassemble.demo==1.7.0, instead of preserving the server's installed1.9.2core stack.This dependency appears to have originally been used as a minimum-version guard for older Docassemble servers, but at this point it is creating upgrade risk for current servers. Removing the core dependency lets Docassemble treat its own core packages as part of the platform rather than something this extension should ask
pipto resolve.Scope
This changes packaging metadata only. Runtime code is unchanged.
Verification
python3 setup.py egg_infosucceeds after this change