Disable golangci-lint staticcheck SA1019#1285
Merged
Conversation
Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
ljkiraly
approved these changes
Apr 17, 2025
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Apr 17, 2025
…d-forwarder-vpp@main PR link: networkservicemesh/cmd-forwarder-vpp#1285 Commit: 5d27e4f Author: Botond Szirtes Date: 2025-04-17 16:36:15 +0200 Message: - Disable golangci-lint staticcheck SA1019 (#1285) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Apr 17, 2025
…d-forwarder-vpp@main (#13125) PR link: networkservicemesh/cmd-forwarder-vpp#1285 Commit: 5d27e4f Author: Botond Szirtes Date: 2025-04-17 16:36:15 +0200 Message: - Disable golangci-lint staticcheck SA1019 (#1285) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
networkservicemesh/deployments-k8s#13105
Description
This PR disables the
SA1019rule fromstaticcheckingolangci-lint, which reports false-positive deprecation warnings. The warning refers to an unresolved deprecation ingrpc-go, where no valid replacement (e.g.,NewClient) currently exists.