Fix older FC nxos interface statistics #2192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
mjbear
changed the title
mjbear
changed the title
jmcgill298
approved these changes
Sep 30, 2025
Comment on lines
+21
to
+41
| fc4/11 is down (Link failure: loss of signal) | ||
| Port description is UCS Cisco Fiber-Channel (FI-B Port 31) | ||
| Hardware is Fibre Channel, SFP is short wave laser w/o OFC (SN) | ||
| Port WWN is 20:cb:00:2a:6a:73:4d:80 | ||
| Admin port mode is auto, trunk mode is on | ||
| snmp link state traps are enabled | ||
| Port vsan is 1 | ||
| Receive data field Size is 2112 | ||
| Beacon is turned off | ||
| 1 minute input rate 0 bits/sec, 0 bytes/sec, 0 frames/sec | ||
| 1 minute output rate 0 bits/sec, 0 bytes/sec, 0 frames/sec | ||
| 95020 frames input, 4941396 bytes | ||
| 0 discards, 0 errors | ||
| 0 CRC, 0 unknown class | ||
| 0 too long, 0 too short | ||
| 95026 frames output, 53208452 bytes | ||
| 0 discards, 0 errors | ||
| 1 input OLS, 1 LRR, 1 NOS, 0 loop inits | ||
| 1 output OLS, 0 LRR, 1 NOS, 0 loop inits | ||
| last clearing of "show interface" counters never | ||
| Interface last changed at Tue Jun 3 11:51:29 2025 No newline at end of file |
There was a problem hiding this comment.
Should the following be captured?
- Port WWN is 20:cb:00:2a:6a:73:4d:80 (as MAC???)
- 0 errors (as output_errors)
- 1 minute input rate 0 bits/sec (as bandwidth_input_rate) (same for output)
there may be some more in the numbers
There was a problem hiding this comment.
- Port WWN
- Like others, I initially took a double take at the WWN, but it has more hex chars than a MAC address
- Errors
- I'm open to capturing it if we think it's worth it -- this would require a state transition
- input/output rates
I'll take a closer look at this since the labels do include (in|out)put 😇- Edit: These are captured and it probably doesn't hurt that they are, right?
|
@mjbear I think we are all set here right? |
@jvanderaa
🙂 Otherwise, I believe we're all set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2191
Match additional unmatched lines related to Fibre Channel.
During past template updates we matched more of the lines and added an Error directive. Unfortunately test data didn't have example raw output from old switches or Fibre Channel so those weren't accounted for (as to be expected).