Skip to content

Fix jnpr_device.JunosDevice.save NamedTemporaryFile mode. #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pszulczewski merged 1 commit into from
Jan 8, 2025
Merged

Fix jnpr_device.JunosDevice.save NamedTemporaryFile mode. #318

pszulczewski merged 1 commit into from
Jan 8, 2025

Conversation

@pszulczewski
Copy link
Contributor

@pszulczewski pszulczewski commented Dec 20, 2024

Fixes npr_device.JunosDevice save method. NamedTemporaryFile should be in mode="w" because config is returned as str instance.

@pszulczewski pszulczewski merged commit c3e0f05 into develop Jan 8, 2025
12 checks passed
@pszulczewski pszulczewski deleted the fix_jnpr_device_NamedTemporaryFile branch January 8, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffkala jeffkala jeffkala approved these changes

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pszulczewski @jeffkala