apc_modbus: Fix invalid memory access for USB vendor/product/serial #3069
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcan
force-pushed
the
apc_modbus_strdup
branch
from
935acbb to
596cfc2
Compare
Signed-off-by: Hector Martin <[email protected]>
marcan
force-pushed
the
apc_modbus_strdup
branch
from
596cfc2 to
f27e4f5
Compare
|
✅ Build nut 2.8.4.3473-master completed (commit 37a1c81193 by @marcan) |
jimklimov
added
bug
APC
modbus
C-str
jimklimov
approved these changes
Sep 2, 2025
|
❌ Build nut 2.8.4.3483-master failed (commit e7a5a81623 by @jimklimov) |
|
CI is somehow laggy this week, gotta check what's with the machine after the current builds complete... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #2289. Only compile tested, but hopefully it should be a fairly obvious fix.