-
Notifications
You must be signed in to change notification settings - Fork 33
Added CLAUDE.md, custom Claude Code slash commands, Husky pre-commit for Prettier, etc. #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @jtviolet's task —— View job Review Tasks:
🎯 Pull Request ReviewThis PR adds comprehensive Claude Code integration for the Netwrix documentation project, including custom commands, formatting workflows, and detailed guidance. Overall, this is a well-structured addition that will significantly improve the developer experience. ✅ Strengths1. CLAUDE.md Documentation
2. Custom Slash Commands
3. Configuration & Setup
4. GitHub Workflows
🔧 Issues & Suggestions1. GitHub Workflows
name: Run Prettier on Should be: name: Run Prettier
if: ${{ github.event.workflow_run.conclusion == 'success' }}This condition checks for
run: echo "::set-output name=config::$(cat algolia/config.json | jq -r tostring)"Should use the new syntax: run: echo "config=$(cat algolia/config.json | jq -r tostring)" >> $GITHUB_OUTPUT2. Custom Commands
MDX CapabilitiesShould be: --ifm-font-family-base: 'Inter', system-uiLine 372: Missing instruction to add 4. Docusaurus Configuration The refactoring from dynamic product discovery to static configuration is a good architectural decision for:
However, consider adding a comment explaining why static configuration was chosen over dynamic discovery. 5. Missing Files The Algolia workflow references 📋 Additional Recommendations
"lint-staged": {
"*.{js,jsx,ts,tsx,json,css,scss,md,html,yml,yaml}": [
"prettier --write"
]
}
✨ Overall AssessmentThis is a high-quality PR that significantly enhances the project's developer experience. The CLAUDE.md file is particularly impressive with its comprehensive coverage and clear instructions. The custom commands are practical and well-documented. With the minor fixes mentioned above, this will be an excellent addition to the project. The shift to static configuration in Recommendation: Approve with minor changes to fix the workflow issues and path inconsistencies. |
|
Claude encountered an error —— View job Review Tasks:
I'll systematically review all changes and provide detailed feedback on code quality, configuration, and documentation. |

Also added Husky for a Prettier precommit.