Skip to content

Conversation

@robin-stefani
Copy link
Contributor

Added new Introduction to Solution courses, adjusted LPs accordingly. Also fixed a few typos and 1k course lengths.
Added new 1Secure core presales demo course.
Added 2 new LTT courses for partners: Threat Manager MCP and NDC v5.7.10

@claude
Copy link

claude bot commented Oct 30, 2025

Pull Request Review

Thank you for this comprehensive training content update! Overall, this PR effectively adds new training courses and updates learning path structures. Here's my detailed feedback:

✅ Positive Aspects

  1. Good Content Organization: The new solution-level introduction courses (1980-1985) follow a consistent pattern across different solutions.
  2. Proper Import Structure: New components are correctly exported from index.js files and imported where needed.
  3. Consistent Formatting: Course descriptions follow the established template with prerequisites and estimated lengths.
  4. Appropriate Time Estimates: The updates to course lengths (5 min → 2 min for many courses) appear more realistic.

🐛 Issues Found

Critical Issues

  1. Typo in Keyword (Line 5 of 1secure-core.md):

    • Found: aud1secureitor
    • Should be: auditor or 1secure
    • Location: docs/partner/presales/1secure-core.md:5
  2. Typo in Link Text (Line 39 of presales/index.md):

    • Found: 1Seccure (double 'c')
    • Should be: 1Secure
    • Location: docs/partner/presales/index.md:39
  3. Typo in Word (Multiple new solution intro files):

    • Found: propresents
    • Should be: presents
    • Locations:
      • src/training/data-security-posture-management/1980.md:7
      • src/training/directory-management/1981.md:7
      • src/training/endpoint-management/1982.md:7
      • src/training/identity-management/1983.md:7
      • src/training/identity-threat-detection-response/1984.md:7
  4. Typo in presales/index.md (Line 6):

    • Found: ceritifcation
    • Should be: certification
    • Location: docs/partner/presales/index.md:6
  5. Typo in presales/index.md (Line 33):

    • Found: Enagineer
    • Should be: Engineer
    • Location: docs/partner/presales/index.md:33

Minor Issues

  1. Grammar/Singular-Plural Inconsistency (endpoint-management.md:19):

    • Text says: It contains the following course: (singular)
    • But lists 2 courses
    • Should be: It contains the following courses: (plural)
    • Location: docs/partner/sales/endpoint-management.md:19
  2. Additional course list in data-classification:

    • New entry added: What's New in <NDC /> v5.7.10
    • Verify this course actually exists in the learning library
    • Location: src/training/data-classification/additional.md:7

📋 Suggestions

  1. Consistency Check: The PAM solution description removes NEPM from the products list. Verify this is intentional and aligns with the current product offerings.

  2. Documentation Clarity: Consider adding brief descriptions to the new solution intro courses (1980-1985) to make them more informative, as they're all currently very short (1 minute).

  3. Navigation: The reorganization moving Platform Governance products from "Additional Products" to "Identity Management Solution" improves categorization.


🔒 Security & Performance

  • ✅ No security concerns identified
  • ✅ No performance issues - documentation changes only
  • ✅ No hardcoded credentials or sensitive data

✅ Test Coverage

  • N/A - This PR contains documentation/content changes only
  • Recommend manual testing of the build to ensure all imports resolve correctly

📝 Summary

This is a solid content update that adds valuable training materials. The main issues are typos that should be corrected before merging:

  • aud1secureitor → correct keyword
  • 1Seccure1Secure
  • propresentspresents (5 instances)
  • ceritifcationcertification
  • EnagineerEngineer
  • course:courses: (singular/plural fix)

Recommendation: Request changes to fix the typos, then approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants