Skip to content

Updated twig to 1.14.0.#24

Draft
sun wants to merge 4 commits intomasterfrom
fix/twigjs-upgrade-sun
Draft

Updated twig to 1.14.0.#24
sun wants to merge 4 commits intomasterfrom
fix/twigjs-upgrade-sun

Conversation

@sun
Copy link
Member

@sun sun commented Feb 4, 2020

This PR fixes the following errors:

Error: TypeError: this.importFile is not a function
    at /Users/sun/sites/nest/bnn/front/templates/node_modules/@netzstrategen/fractal-twig/src/adapter.js:286:24
    at new Promise ()
    at TwigAdapter.render (/Users/sun/sites/nest/bnn/front/templates/node_modules/@netzstrategen/fractal-twig/src/adapter.js:272:16)
    at ComponentSource._renderVariant (/Users/sun/sites/nest/bnn/front/templates/node_modules/@frctl/fractal/src/api/components/source.js:207:30)
    at _renderVariant.next ()

Upstream: https://github.com/twigjs/twig.js/blob/524e6cf974618d1a0ea8d832015ca9f8958a3564/src/twig.logic.js#L817

Error: TypeError: Cannot read property 'call' of undefined
    at /Users/sun/sites/nest/bnn/front/templates/node_modules/@netzstrategen/fractal-twig/src/adapter.js:286:24
    at new Promise ()
    at TwigAdapter.render (/Users/sun/sites/nest/bnn/front/templates/node_modules/@netzstrategen/fractal-twig/src/adapter.js:272:16)
    at ComponentSource._wrapInLayout (/Users/sun/sites/nest/bnn/front/templates/node_modules/@frctl/fractal/src/api/components/source.js:269:43)
    at _wrapInLayout.next ()
    at onFulfilled (/Users/sun/sites/nest/bnn/front/templates/node_modules/co/index.js:65:19)

Upstream: Twig.expression.parseAsync.call(): https://github.com/twigjs/twig.js/blob/326c59e5d6069ac901aa441b00faebc849b689d1/src/twig.core.js#L990

@sun
Copy link
Member Author

sun commented Feb 4, 2020

It's possible we additionally have to incorporate #5 now.

@colourgarden
Copy link
Contributor

@sun Status?

@fabianmarz
Copy link
Member

ping @sun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants