Open
Conversation
neubig
requested changes
Dec 31, 2023
Collaborator
neubig
left a comment
neubig
left a comment
There was a problem hiding this comment.
Thanks for contributing this!
I think that using explanations should probably be optional though. It's not the same as what we did in the prompt2model paper, and I'm not convinced that it will be useful in all cases. I know this is a pretty big change to this PR (and I don't suggest this lightly), but could you please consider adding a flag that makes it possible to either use or not use explanations? Thank you!
| """An example from a dataset, containing input, explanation and output columns.""" | ||
|
|
||
| input_col: str | ||
| explain_col: str |
Collaborator
There was a problem hiding this comment.
I would suggest that we just call this explanation_col to be consistent. Also, it's not clear what an explanation is. I'd suggest that you expand the docstring and describe what all the variables are.
Suggested change
| explain_col: str | |
| explanation_col: str |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added explanation column to the dataset generation and modified the prompt templates to include explanations
References
Chain-of-thought prompting
Blocked by