Refactor module / parameter matching logic #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
…_or_class_matches` Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
kylesayrs
reviewed
Jul 29, 2025
Removed `yield_matched_targets` and `warn_on_unmatched_ignores` and updated rest of code Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
kylesayrs
reviewed
Jul 29, 2025
kylesayrs
reviewed
Jul 29, 2025
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
This function is currently used by llm-compressor so adding it back with a deprecation warning for now. Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
brian-dellabetta
previously approved these changes
Aug 7, 2025
kylesayrs
reviewed
Aug 20, 2025
kylesayrs
reviewed
Aug 20, 2025
kylesayrs
reviewed
Aug 20, 2025
brian-dellabetta
approved these changes
Aug 20, 2025
kylesayrs
added a commit
that referenced
this pull request
Aug 20, 2025
This reverts commit d99d38b.
kylesayrs
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Update `apply_quantiation_config` to use `match_named_modules` Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Refactor usages of `expand_target_names`, `is_target`, and `find_name_or_class_matches` Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Small fixes Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Simplify signature of `match_named_modules` Removed `yield_matched_targets` and `warn_on_unmatched_ignores` and updated rest of code Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Ensure `match_targets` doesn't return duplicates Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Remove `preprocess_name` parameter from `match_named_modules` Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Update match.py util fn signatures and small fixes Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Restore `find_name_or_class_matches` as a deprecated function This function is currently used by llm-compressor so adding it back with a deprecation warning for now. Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Use deprecated decorator instead of manual deprecation warning Signed-off-by: Fynn Schmitt-Ulms <[email protected]> * Update syntax of of optional types * Remove default None target value in match utils --------- Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
kylesayrs
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #405
match_named_modulesmatch_named_modules