Skip to content

Refactor module / parameter matching logic #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 21, 2025
Merged

Refactor module / parameter matching logic #431

merged 14 commits into from
Aug 21, 2025

Conversation

fynnsu
Copy link
Contributor

@fynnsu fynnsu commented Aug 21, 2025

Reopen #406

fynnsu added 13 commits July 29, 2025 15:17
@fynnsu
Update apply_quantiation_config to use match_named_modules
ad74d32 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Refactor usages of expand_target_names, is_target, and `find_name…
72a6c65 
…_or_class_matches`

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Small fixes
01e75b2 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Simplify signature of match_named_modules
d22149f 
Removed `yield_matched_targets` and `warn_on_unmatched_ignores` and updated rest of code

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Ensure match_targets doesn't return duplicates
d94f655 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Remove preprocess_name parameter from match_named_modules
b1fa4df 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Update match.py util fn signatures and small fixes
4283b1d 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Restore find_name_or_class_matches as a deprecated function
70b07ec 
This function is currently used by llm-compressor so adding it back with a deprecation warning for now. 

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Merge main into refactor_utils
074475e 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Use deprecated decorator instead of manual deprecation warning
1520a25 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Merge main into refactor_utils
ac049db
@fynnsu
Update syntax of of optional types
4c21a8f
@fynnsu
Remove default None target value in match utils
c9b8ba2
@fynnsu fynnsu mentioned this pull request Aug 21, 2025
Closed
kylesayrs
kylesayrs reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@kylesayrs kylesayrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: see next comment

kylesayrs
kylesayrs reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this part removed?

kylesayrs
kylesayrs approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@fynnsu fynnsu merged commit d4354b0 into neuralmagic:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@kylesayrs kylesayrs kylesayrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fynnsu @brian-dellabetta @kylesayrs