-
Notifications
You must be signed in to change notification settings - Fork 33
[Attention] Attention head quantization strategy #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylesayrs
wants to merge
7
commits into
kylesayrs/refactor-initialize-tests
Choose a base branch
from
kylesayrs/add-attn-head-strat
base: kylesayrs/refactor-initialize-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Attention] Attention head quantization strategy #481
kylesayrs
wants to merge
7
commits into
kylesayrs/refactor-initialize-tests
from
kylesayrs/add-attn-head-strat
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf00a99
to
2ea692d
Compare
97a4d16
to
0fdfbd1
Compare
2ea692d
to
326f802
Compare
0fdfbd1
to
8973328
Compare
326f802
to
6a13bc4
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
70da261
to
48875e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we expecting users to use QuantizationStrategy.ATTN_HEAD
in a recipe? If i'm understanding correctly, it would look something like this?
quant_stage:
quant_modifiers:
QuantizationModifier:
config_groups:
group0:
targets: ["re:.*self_attn$"]
weights:
strategy: attn_head
...
group1:
targets: ["re:.*(q|k|v)_proj$"]
weights:
strategy: group
...
@brian-dellabetta I’ve decided that giving per-attention strategy its own strategy (rather than reusing group) makes more sense. quant_stage:
quant_modifiers:
QuantizationModifier:
config_groups:
group0:
targets: ["re:.*self_attn$"]
input_activations:
strategy: attn_head
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prerequisites
Changes
Testing