feat: prompt user - unsaved changes & nav away#46
Draft
xgui3783 wants to merge 1 commit intoneuroanatomy:masterfrom
Draft
feat: prompt user - unsaved changes & nav away#46xgui3783 wants to merge 1 commit intoneuroanatomy:masterfrom
xgui3783 wants to merge 1 commit intoneuroanatomy:masterfrom
Conversation
Author
|
Unfortunately, I can't seem to test this functionality properly. The bundled images seems to have I will have to take a better look when I get a chance. |
Member
|
Thank you so much for implementing this alert! 🌟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
npm testsuccessfully.Run
npm run mochasuccessfully.test_screenshotsgenerates the same test pictures intestas there were intest/referenceand does not show any errors(I don't think new screenshots are generated properly?)
I implemented tests for the new changes OR
These changes do not require tests because _____
These changes fix Alert user before closing without saving #36