Loosen the requirement for numeric labels to allow alphanumeric labels.#75
Merged
JoeZiminski merged 4 commits intomainfrom Sep 16, 2025
Merged
Loosen the requirement for numeric labels to allow alphanumeric labels.#75JoeZiminski merged 4 commits intomainfrom
JoeZiminski merged 4 commits intomainfrom
Conversation
niksirbi
approved these changes
Jul 30, 2025
Member
niksirbi
left a comment
niksirbi
left a comment
There was a problem hiding this comment.
Looks good @JoeZiminski, I just have 1 suggestion.
Member
Author
|
This is done on the NeuroBlueprint side, it can be merged and a new release in conjunction with datashuttle once this is merged. |
Member
Author
|
Now merged in datashuttle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to #74 this PR allows
sub-andses-labels to be alphanumeric, removing the requirement for these to be numeric only. It is still recommended that labels are (optionally zero-padded) integers increasing as each new subject / session is added, but this is no longer a fixed requirement.thanks @glopesdev for the suggestion! It is nice to allow this level of flexibility if required.
This PR is a change to the spec so does not require tests nor further documentation. It will need to be handled on the datashuttle side and would make sense to merge this and a datashuttle PR that handles it at the same tiem.