-
Notifications
You must be signed in to change notification settings - Fork 34
Add project folders framework #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cursive subfolder generation
adamltyson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gone through in too much detail, but all looks good. I've left a few specific comments. More generally, it would be useful to start adding docs and tests now so it's easier for other to test it as it develops.
manager.py is also a very long file, and hard to review. I'd move as much code out into other modules as possible.
Lastly, the code line length is formatted, but it would be good to do the same with the docstrings. Some are very long.
agree, have factored out configs and some utils. ATM utils of different type (ssh, directory managerment) are combined into a utils file but will be worth factoring out of separate files as it gros.
thanks have done. Am currently writing tests which will be useful to see how optimal pyftpsync is for our needs. It might be worth using rysnc / robocopy directly rather than pyftpsync which uses sftp commands directly, but doesn't provide as much extra checking (e.g. checksum options). |
Sounds good. I guess there's a package out there for doing these checks? |
No description provided.