Handle empty string case. #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
force-pushed
the
fix_empty_path_case
branch
from
6b79ef2 to
152a13c
Compare
niksirbi
approved these changes
Nov 20, 2025
Member
|
Looks good @JoeZiminski. Feel free to merge this when it suits you. |
Member
Author
|
cheers @niksirbi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that occurs when an empty string is passed as a local or central path. The string was not being converted to path as the value can be a string, Path or
Noneand onlyif valuewas checked, so the empty string case was being treated asNone, then not being converted to Path, leading to an error elsewhere.