-
Notifications
You must be signed in to change notification settings - Fork 34
Fix directorytree focus issue #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the codebase to be compatible with Textual version 3.4.0 and later. While the title mentions fixing a directorytree focus issue, the actual focus fix implementation is not included in the provided diffs. The changes primarily address API compatibility updates and dependency management.
Key Changes:
- Updated test assertions from
.renderableto.render().plainto match newer Textual API - Relaxed Textual dependency from pinned version to minimum version constraint
- Changed widget usage from
StatictoLabelin setup_gdrive.py
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tests_tui/tui_configs_base.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_tui_widgets_and_defaults.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_tui_logging.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_tui_get_help.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_tui_directorytree.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_tui_create_folders.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_tui_configs.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_tui/test_local_only_project.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_transfers/gdrive/test_tui_setup_gdrive.py | Updated test assertions to use .render().plain instead of .renderable |
| tests/tests_transfers/aws/test_tui_setup_aws.py | Updated test assertions to use .render().plain instead of .renderable |
| pyproject.toml | Changed textual dependency from exact version ==3.4.0 to minimum version >=3.4.0 |
| datashuttle/tui/screens/setup_gdrive.py | Changed import and usage from Static to Label widget |
| .github/workflows/code_test_and_deploy.yml | Reordered test execution to run general tests before specialized connection tests |
Comments suppressed due to low confidence (1)
pyproject.toml:22
- Changing from a pinned version
textual==3.4.0to a minimum version constrainttextual>=3.4.0may introduce compatibility issues with future versions of textual that could break the application. Consider using an upper bound constraint liketextual>=3.4.0,<4.0.0to allow patch and minor version updates while preventing potentially breaking major version changes.
"textual>=3.4.0",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
26897df to
a1fc141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR fixes an issue (mentioned in #618) that required clicking on the directory tree widget (e.g. a particular folder) before it was possible to use the keyboard shortcut. Now the widget grabs focus on mouse move so clicking the widget to give it focus is not necessary.
To test this PR, going to the directory tree and pressing
CTRL+Owhile holding the mouse over a folder should open it in the finder. You shouldn't need to click on the widget before doing this for it to work.