Run multiple datasets and evaluate quality of derotation#38
Merged
lauraporta merged 27 commits intomainfrom Mar 17, 2025
Merged
Run multiple datasets and evaluate quality of derotation#38lauraporta merged 27 commits intomainfrom
lauraporta merged 27 commits intomainfrom
Conversation
lauraporta
force-pushed
the
metrics-and-batch
branch
from
c4fa48d to
97cab25
Compare
This was
linked to
issues
Mar 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 51.56% 43.71% -7.86%
==========================================
Files 9 13 +4
Lines 894 1153 +259
==========================================
+ Hits 461 504 +43
- Misses 433 649 +216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…in certain datasets
Member
IgorTatarnikov
left a comment
IgorTatarnikov
left a comment
There was a problem hiding this comment.
Here are my comments so far, will continue once the bug fixes are in!
derotation/analysis/metrics.py
Outdated
| ) # Add cluster labels | ||
|
|
||
| cluster_counts = Counter(all_blobs[:, -1]) # Cluster labels | ||
| most_detected_label = max(cluster_counts, key=cluster_counts.get) |
Member
There was a problem hiding this comment.
Can also call cluster_counts.most_common(1)[0]
Member
Author
There was a problem hiding this comment.
don't know why this suggestion was not working 🤔
Co-authored-by: Igor Tatarnikov <61896994+IgorTatarnikov@users.noreply.github.com>
IgorTatarnikov
approved these changes
Mar 17, 2025
Member
IgorTatarnikov
left a comment
IgorTatarnikov
left a comment
There was a problem hiding this comment.
Looks good! Just a few extra comments with some issues I ran into while trying to run the pipeline on the example data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
This new PR adds essential adaptations to run derotation on multiple datasets, which include fixing some bugs that were not evident and refined strategies to find the center of rotation.
What does this PR do?
Center of rotation can be found in two ways:
calculate_mean_imageshas been exported in a separate file.Running on multiple datasets via an external call:
config.ymlfile has been updated to expose parameters useful for the BO.Other minor adjustments are present, including calculations of angular velocity and related debugging plot! Very useful when dealing with different datasets that might have motor artefacts...
A few examples of the new plots:
References
Issues linked.
How has this PR been tested?
Previous tests pass.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
N/A
Checklist: