Add unit tests for fit_ellipse_to_points to address issue #36#39
Closed
onemriganka wants to merge 1 commit intoneuroinformatics-unit:mainfrom
onemriganka:add-fit-ellipse-tests
Closed
Add unit tests for fit_ellipse_to_points to address issue #36#39onemriganka wants to merge 1 commit intoneuroinformatics-unit:mainfrom onemriganka:add-fit-ellipse-tests
onemriganka wants to merge 1 commit intoneuroinformatics-unit:mainfrom
onemriganka:add-fit-ellipse-tests
Conversation
Member
|
Hi @onemriganka, thanks for your PR! I'm going to review it and give some feedback. |
Member
|
@onemriganka, I see the linting check is not passing. Was the code formatted locally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes / #36
Description
What is this PR
Why is this PR needed?
This PR addresses issue [#36](#36) by adding dedicated unit tests for the
fit_ellipse_to_pointsfunction. While the function is indirectly tested through integration tests, a specific unit test ensures that the ellipse center is correctly computed from a synthetic, well-defined set of points.What does this PR do?
tests/test_fit_ellipse.py) that:generate_ellipse_pointsto create a synthetic ellipse dataset with known parameters.test_fit_ellipse_center) to verify that the computed ellipse center fromfit_ellipse_to_pointsis within an acceptable tolerance of the expected center.pytest.References
fit_ellipse_to_points#36)How has this PR been tested?
The new unit test has been executed locally using
pytest. The test suite passes without errors, ensuring that the new test does not affect any existing functionality.Is this a breaking change?
No, this PR does not break any existing functionality.
Does this PR require an update to the documentation?
Yes. The README has been updated to include instructions for running the tests, making it easier for contributors to verify their changes.
Checklist: