Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 44.12% 43.69% -0.44%
==========================================
Files 13 14 +1
Lines 1115 1126 +11
==========================================
Hits 492 492
- Misses 623 634 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
niksirbi
approved these changes
Jul 3, 2025
Member
niksirbi
left a comment
There was a problem hiding this comment.
Looks good to me! I think this should fix your binder problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Binder notebooks were failing as I didn't included the
examples/data/folder in the repository. I now have uploaded it to jin and I am downloading it from there.What does this PR do?
Adds file with small function containing variables for
pooch(maybe too hardcoded?) and edits the examples.References
Solves #44
How has this PR been tested?
Local website built - cannot test binder 😭
Is this a breaking change?
no
Does this PR require an update to the documentation?
API docs included with docstring
Checklist: