Skip to content

Use pooch to retrieve data from gin#47

Merged
lauraporta merged 4 commits intomainfrom
data-from-gin-fro-binder
Jul 24, 2025
Merged

Use pooch to retrieve data from gin#47
lauraporta merged 4 commits intomainfrom
data-from-gin-fro-binder

Conversation

@lauraporta
Copy link
Copy Markdown
Member

@lauraporta lauraporta commented Jul 1, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Binder notebooks were failing as I didn't included the examples/data/ folder in the repository. I now have uploaded it to jin and I am downloading it from there.

What does this PR do?
Adds file with small function containing variables for pooch (maybe too hardcoded?) and edits the examples.

References

Solves #44

How has this PR been tested?

Local website built - cannot test binder 😭

Is this a breaking change?

no

Does this PR require an update to the documentation?

API docs included with docstring

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 43.69%. Comparing base (8d2984a) to head (c059d10).

Files with missing lines Patch % Lines
derotation/sample_data.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   44.12%   43.69%   -0.44%     
==========================================
  Files          13       14       +1     
  Lines        1115     1126      +11     
==========================================
  Hits          492      492              
- Misses        623      634      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lauraporta lauraporta requested a review from niksirbi July 3, 2025 14:33
Copy link
Copy Markdown
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think this should fix your binder problems.

@lauraporta lauraporta merged commit c5244ba into main Jul 24, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants