Fix intermittent crash with multiprocessing-aware logging #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
multiprocessing_aware=Truecan intermittently trigger shutdown errors whenmultiprocessing_loggingis installed bcoz background logging threads may access closed pipe handles even in single-process exec.What does this PR do?
multiprocessing_logginghandler in the main process and only enables it when running inside child processes.References
How has this PR been tested?
start_logging()withmultiprocessing_aware=Trueboth with and without spawning child processes.Is this a breaking change?
Does this PR require an update to the documentation?
Checklist: