Update mypy configuration and fix errors

[lochhh]

Description

What is this PR

• Bug fix
• Addition of a new feature
• Other

Why is this PR needed?
This PR closes #723

What does this PR do?
This PR

• adds missing typed dependencies to .pre-commit-config.yaml; but pre-commit.ci now fails with the following error:

  build of https://github.com/pre-commit/mirrors-mypy:attrs,types-setuptools,pandas-stubs,types-attrs,types-PyYAML,types-requests,xarray,scipy-stubs,types-shapely,[email protected] for [email protected] exceeds tier max size 250MiB: 292.2MiB

• skips mypy for pre-commit.ci (the linting step will still run the full pre-commit with mypy)
• restricts mypy (both pre-commit-config.yaml and pyproject.toml) to run on the movement package only (we can extend this later to cover tests or more dirs)
• resolves all mypy errors
• refactors the roi and plots modules

References

#723

How has this PR been tested?

Tests have been updated for refactors; tests continue to pass.

Is this a breaking change?

No

Does this PR require an update to the documentation?

docstrings have been updated accordingly.

Checklist:

• The code has been tested locally
• Tests have been added to cover all new functionality
• The documentation has been updated to reflect any changes
• The code has been formatted with pre-commit

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e41a5d0) to head (141a026).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #721   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2109      2104    -5     
=========================================
- Hits          2109      2104    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[niksirbi]

Thanks for undertaking this @lochhh.

It must have been a massive amount of work, especially the bits about ROIs and broadcasting.

As far as I can tell, everything works fine now. I'm approving this but will leave you to deal with the merging. This PR is probably going to lead to many merge conflicts, especially with PR 727, but it's probably best to bite the bullet and merge this one soon.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud