Skip to content

Conversation

@lochhh
Copy link
Member

@lochhh lochhh commented Jan 5, 2026

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
This PR closes #743

What does this PR do?
This PR removes the manifest job from test_and_deploy.yml, keeping the one in pre-commit-config.yaml, so that we can get fast feedback locally, and pre-commit.ci will also run this check remotely. This keeps the CI steps simple.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (93ebf88) to head (c4f5d05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #744   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2109      2109           
=========================================
  Hits          2109      2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lochhh lochhh marked this pull request as ready for review January 5, 2026 17:38
@lochhh lochhh requested a review from a team January 6, 2026 10:33
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @lochhh.

Btw, this duplication is probably widespread across many of our projects. I've only checked ethology so far, and it's there too.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@niksirbi niksirbi added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 5750b4c Jan 7, 2026
25 checks passed
@niksirbi niksirbi deleted the check-manifest branch January 7, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated check-manifest step

3 participants