improve: add supported options to deprecated loader errors#860
Open
dhruv1955 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
improve: add supported options to deprecated loader errors#860dhruv1955 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
dhruv1955 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
What is this PR
Why is this PR needed?
Deprecated loader wrappers (
load_poses.from_fileandload_bboxes.from_file) raised generic unsupported-source errors that did not tell users which values are valid. This made troubleshooting harder, especially when migrating to the unified loading API.What does this PR do?
source_softwareerrors in:movement.io.load_poses.from_filemovement.io.load_bboxes.from_file"Supported options are: ..."list of valid values"Unsupported source software"appears"Supported options are:"appearsReferences
No linked issue for this PR.
How has this PR been tested?
ruff check movement/io/load_poses.py movement/io/load_bboxes.py tests/test_unit/test_io/test_load_poses.py tests/test_unit/test_io/test_load_bboxes.pypytestinvocation is currently blocked in this environment by external sample-data download timeouts from GIN duringtests/conftest.pysession startup.Is this a breaking change?
No.
This change only improves error messages and test assertions for deprecated wrapper functions. No functional behavior or API contract is changed.
Does this PR require an update to the documentation?
No.
No public API behavior changed beyond clearer error messaging.
Checklist: