fix: replace .roll() with .shift() in compute_backward_displacement#866
Open
hemantyaduvanshi585-cmd wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
fix: replace .roll() with .shift() in compute_backward_displacement#866hemantyaduvanshi585-cmd wants to merge 1 commit intoneuroinformatics-unit:mainfrom
hemantyaduvanshi585-cmd wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
Using .roll(time=1) caused the last frame's displacement to wrap around to the first frame, which is physically incorrect. I've replaced it with .shift(time=1, fill_value=0) to ensure the first frame is correctly initialized to 0 and to prevent data leakage from the end of the sequence.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, compute_backward_displacement uses .roll(time=1). This causes the last frame's position to "wrap around" and affect the first frame's displacement calculation. In a real trajectory, the first frame shouldn't have a backward displacement from the last frame—it should be 0.