Skip to content

fix: remove deprecated from_file and from_multiview_files (#812)#878

Open
mujju-212 wants to merge 2 commits intoneuroinformatics-unit:mainfrom
mujju-212:fix/812-remove-deprecated-from-file
Open

fix: remove deprecated from_file and from_multiview_files (#812)#878
mujju-212 wants to merge 2 commits intoneuroinformatics-unit:mainfrom
mujju-212:fix/812-remove-deprecated-from-file

Conversation

@mujju-212
Copy link

Summary

Closes #812

Following the merging of PR #722, which introduced load.load_dataset() and load.load_multiview_dataset() as replacements and added deprecation warnings to the old dataset-specific functions, this PR removes those now-deprecated functions entirely.

Changes

  • movement/io/load_poses.py: Removed from_file() and from_multiview_files() functions, along with now-unused import warnings.
  • movement/io/load_bboxes.py: Removed from_file() function, along with now-unused import warnings.
  • tests/test_unit/test_io/test_load_poses.py: Removed test_from_file_delegates_correctly() and test_from_multiview_files() tests, along with now-unused from unittest.mock import patch.
  • tests/test_unit/test_io/test_load_bboxes.py: Removed test_from_file() test, along with now-unused from unittest.mock import patch.
  • tests/test_unit/test_deprecations.py: Removed the three parametrize entries for load_poses.from_file, load_poses.from_multiview_files, and load_bboxes.from_file; cleaned up now-unused imports (xarray, load_bboxes, load_poses, patch).

Type of change

  • Bug fix / maintenance (removal of deprecated code)

@niksirbi
Copy link
Member

niksirbi commented Mar 9, 2026

Thanks for your interest in contributing to movement @mujju-212.

We don't want to remove the deprecations just yet as we wish to allow some more time for our users to adjust their workflow to the new syntax.

I propose tackling the removal after we make the next release, so that it goes in effect with the release after that.

Therefore, I'm converting this PR to draft for now, but you are welcome to come back to it after we make our next release (hopefully within the week). At that point you'll need to start by rebasing your branch to our main.

@niksirbi niksirbi marked this pull request as draft March 9, 2026 10:47
@mujju-212
Copy link
Author

Thanks for the explanation! That makes complete sense — keeping the deprecation warnings live a bit longer gives users the time they need to migrate to the new API before it's removed. Happy to wait until after the next release. I'll keep an eye on the repo and come back to rebase and mark this ready for review once the release is out. Let me know if anything else needs adjusting in the meantime!

@niksirbi
Copy link
Member

Hey @mujju-212, since we managed to make a release yesterday already, you may go ahead with rebasing this PR. Mark it as ready to review when that is done and CI checks pass.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8d49d6a) to head (c4bb2d0).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #878   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2284      2256   -28     
=========================================
- Hits          2284      2256   -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…matics-unit#812)

Remove the dataset-specific from_file and from_multiview_files functions
that were deprecated in PR neuroinformatics-unit#722. Also remove the tests for these
functions and clean up now-unused imports.

Closes neuroinformatics-unit#812
@mujju-212 mujju-212 force-pushed the fix/812-remove-deprecated-from-file branch from c4bb2d0 to 63d570f Compare March 11, 2026 18:25
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@mujju-212 mujju-212 marked this pull request as ready for review March 11, 2026 18:32
@mujju-212
Copy link
Author

Hi @niksirbi, done! I've rebased this branch onto the latest main, resolved the merge conflicts, and all CI checks (SonarQube and Codecov) are passing at 100% coverage. I've marked the PR as ready for review. Thanks for the heads-up about the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate dataset-specific from_file and from_multiview_files

2 participants