fix: remove deprecated from_file and from_multiview_files (#812)#878
fix: remove deprecated from_file and from_multiview_files (#812)#878mujju-212 wants to merge 2 commits intoneuroinformatics-unit:mainfrom
from_file and from_multiview_files (#812)#878Conversation
|
Thanks for your interest in contributing to We don't want to remove the deprecations just yet as we wish to allow some more time for our users to adjust their workflow to the new syntax. I propose tackling the removal after we make the next release, so that it goes in effect with the release after that. Therefore, I'm converting this PR to draft for now, but you are welcome to come back to it after we make our next release (hopefully within the week). At that point you'll need to start by rebasing your branch to our |
|
Thanks for the explanation! That makes complete sense — keeping the deprecation warnings live a bit longer gives users the time they need to migrate to the new API before it's removed. Happy to wait until after the next release. I'll keep an eye on the repo and come back to rebase and mark this ready for review once the release is out. Let me know if anything else needs adjusting in the meantime! |
|
Hey @mujju-212, since we managed to make a release yesterday already, you may go ahead with rebasing this PR. Mark it as ready to review when that is done and CI checks pass. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 2284 2256 -28
=========================================
- Hits 2284 2256 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…matics-unit#812) Remove the dataset-specific from_file and from_multiview_files functions that were deprecated in PR neuroinformatics-unit#722. Also remove the tests for these functions and clean up now-unused imports. Closes neuroinformatics-unit#812
c4bb2d0 to
63d570f
Compare
for more information, see https://pre-commit.ci
|
|
❌ The last analysis has failed. |
|
Hi @niksirbi, done! I've rebased this branch onto the latest |



Summary
Closes #812
Following the merging of PR #722, which introduced
load.load_dataset()andload.load_multiview_dataset()as replacements and added deprecation warnings to the old dataset-specific functions, this PR removes those now-deprecated functions entirely.Changes
movement/io/load_poses.py: Removedfrom_file()andfrom_multiview_files()functions, along with now-unusedimport warnings.movement/io/load_bboxes.py: Removedfrom_file()function, along with now-unusedimport warnings.tests/test_unit/test_io/test_load_poses.py: Removedtest_from_file_delegates_correctly()andtest_from_multiview_files()tests, along with now-unusedfrom unittest.mock import patch.tests/test_unit/test_io/test_load_bboxes.py: Removedtest_from_file()test, along with now-unusedfrom unittest.mock import patch.tests/test_unit/test_deprecations.py: Removed the three parametrize entries forload_poses.from_file,load_poses.from_multiview_files, andload_bboxes.from_file; cleaned up now-unused imports (xarray,load_bboxes,load_poses,patch).Type of change