-
Notifications
You must be signed in to change notification settings - Fork 126
Fix rolling_filter window=1 edge case by returning early and add test #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VPK570
wants to merge
8
commits into
neuroinformatics-unit:main
Choose a base branch
from
VPK570:fix/rolling-filter-window-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a21bca9
Fix rolling_filter window=1 edge case by returning early and add test
VPK570 2010e15
Fix rolling_filter window=1 edge case by returning early and add test
VPK570 c1b3884
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 854e6b2
Fix SonarCloud warnings in rolling_filter window=1 test
VPK570 5006542
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] eb8ec41
Resolve merge conflict in test_rolling_filter_window_1
VPK570 c80bac9
Resolve merge conflict in test_rolling_filter_window_1
VPK570 c8e3f8e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / SonarCloud
Results that depend on random number generation should be reproducible Low test