Move NWB test expectations to YAML#890
Open
ishan372or wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
Move NWB test expectations to YAML#890ishan372or wants to merge 1 commit intoneuroinformatics-unit:mainfrom
ishan372or wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 2284 2284
=========================================
Hits 2284 2284 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
What is this PR
Why is this PR needed?
Some NWB test expectation data was previously defined directly inside the test file (
test_save_poses.py). Separating test data from test logic improves readability and maintainability, and makes it easier to modify or extend expectations without changing the test implementation.What does this PR do?
Moves the NWB expectation dictionaries into a YAML file:
tests/data/nwb_expectations.yamland loads the test expectations in test_save_poses.py usingyaml.safe_loadReferences
Solves #602
How has this PR been tested?
All tests were executed locally using pytest.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No documentation updates are required, as this change only affects internal test organization.
Checklist: