Skip to content

Move NWB test expectations to YAML#890

Open
ishan372or wants to merge 1 commit intoneuroinformatics-unit:mainfrom
ishan372or:seperate-test-data-logic
Open

Move NWB test expectations to YAML#890
ishan372or wants to merge 1 commit intoneuroinformatics-unit:mainfrom
ishan372or:seperate-test-data-logic

Conversation

@ishan372or
Copy link
Contributor

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Some NWB test expectation data was previously defined directly inside the test file (test_save_poses.py). Separating test data from test logic improves readability and maintainability, and makes it easier to modify or extend expectations without changing the test implementation.

What does this PR do?

Moves the NWB expectation dictionaries into a YAML file: tests/data/nwb_expectations.yaml and loads the test expectations in test_save_poses.py using yaml.safe_load

References

Solves #602

How has this PR been tested?

All tests were executed locally using pytest.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No documentation updates are required, as this change only affects internal test organization.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (961656a) to head (364bcbd).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #890   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2284      2284           
=========================================
  Hits          2284      2284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant