Skip to content

Standardise make files#35

Merged
niksirbi merged 3 commits intomainfrom
make-bat
Mar 25, 2026
Merged

Standardise make files#35
niksirbi merged 3 commits intomainfrom
make-bat

Conversation

@lochhh
Copy link
Copy Markdown
Member

@lochhh lochhh commented Mar 17, 2026

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

What does this PR do?
Standardises Makefile and make.bat

  • make.bat behaviour now matches Makefile
    • accepts chained targets, e.g. .\make clean html instead of .\make clean && .\make html
    • clean target removes the same files as Makefile
  • clean target now additionally removes sg_execution_times.rst

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@lochhh lochhh requested a review from a team March 17, 2026 16:45
Copy link
Copy Markdown
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lochhh! LGTM.

I've also set use-make: true in CI (see 0d0b7b3), because why not. This way the workflow is more closely aligned to that of movement.

@niksirbi niksirbi merged commit fa975c1 into main Mar 25, 2026
24 checks passed
@niksirbi niksirbi deleted the make-bat branch March 25, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants