Skip to content

Update precommit config inside package #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Update precommit config inside package #128

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5357d19
Update ruff precommit following PR #127
sfmig Nov 5, 2024
9359be6
Update pre-commit hooks version to match outer precommit file
sfmig Nov 5, 2024
08651cd
Update mypy and check-manifest in template precommit file (they dont …
sfmig Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions {{cookiecutter.package_name}}/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ci:

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
rev: v5.0.0
hooks:
- id: check-docstring-first
- id: check-executables-have-shebangs
Expand All @@ -19,19 +19,21 @@ repos:
args: [--fix=lf]
- id: requirements-txt-fixer
- id: trailing-whitespace
- repo: https://github.com/charliermarsh/ruff-pre-commit
Copy link
Member

@adamltyson adamltyson Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've forgotten to do this for a while!

rev: v0.6.3
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.7.2
hooks:
- id: ruff
args: [ --config=pyproject.toml ]
- id: ruff-format
args: [ --config=pyproject.toml ]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.10.1
rev: v1.13.0
hooks:
- id: mypy
additional_dependencies:
- types-setuptools
- repo: https://github.com/mgedmin/check-manifest
rev: "0.49"
rev: "0.50"
hooks:
- id: check-manifest
args: [--no-build-isolation]
Expand Down
Loading