Add generic root-level template macro for non-datatype directories #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create make_root_filename_template macro for root-level directories like /stimuli - Update bidsschematools to skip path-based rules (without datatypes) in entity table and filename templates - Remove stimuli from entity-table.md as it doesn't follow subject-scoped entity ordering - Dynamically look up entity definitions from schema instead of hardcoding mappings
The test was failing because it tried to access datatypes attribute on all rules, including the new stimuli rules that use path-based organization instead.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
… stimuli tables - Add explicit schema path loading to make_sidecar_table to avoid caching issues - Temporarily comment out stimuli.Stimuli tables that need namespace fixes - File tree generation from schema is now working for /stimuli directory
- Fix entity format labels in root template macro (use <label> instead of hardcoded) - Add explicit schema loading to make_columns_table to avoid caching issues - Re-enable all stimuli tables (sidecar and columns) that now work correctly - File tree now properly shows stim-<label>[_part-<label>] format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make_root_filename_templatemacro for root-level directories like/stimuliChanges
New macro
make_root_filename_template:pathinstead ofdatatypesstimulus→stim)/codeFixed bidsschematools compatibility:
make_entity_table: Skip rules without datatypesmake_filename_template: Skip rules without datatypesUpdated stimuli.md:
Test
The documentation builds successfully:
This contributes to PR bids-standard#2022 for the stimuli BEP implementation.