[ENH] add band, order, and frequency args to eda_process#99
Open
jdkent wants to merge 1 commit intoneuropsychology:masterfrom
Open
[ENH] add band, order, and frequency args to eda_process#99jdkent wants to merge 1 commit intoneuropsychology:masterfrom
jdkent wants to merge 1 commit intoneuropsychology:masterfrom
Conversation
Member
|
Hey @jdkent, Thanks a lot!! I'll probably merge this soon, but I am currently absolutely swamped with other projects. Also, please do note than I am thinking more and more about a reimplementation of a "NeuroKit 2" that would be more stable, correct, fast, clean and narrow-focused (around bio/neuro-signal processing). I think it could be interesting to start such a new project in collaboration with interested people. Please let me know if that's something you would be interested in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #98
Since I had to make the change for our lab anyway, I thought I may as well open a pull request. Let me know if this functionality is not desired.