Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes inference and vLLM parameters into configuration constants, refactors core VRAM calculation functions to use those constants, and removes the CPU resources UI and related CPU calculations.
- Introduce
INFERENCE_CONFIGandVLLM_CONFIGto manage empirical parameters - Refactor
calculateKVCache,calculateActivations,calculateFrameworkOverhead,calculateMultiDeviceOverhead, andestimateGenerationSpeedto use new configs - Remove CPU memory/cores calculation logic and the corresponding UI section
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/vram-calculator/VramCalculatorPage.tsx | Remove CPU resources block; drop unused type & Label imports |
| src/lib/vram-calculator.ts | Add config constants, refactor calculation functions, remove CPU logic |
Comments suppressed due to low confidence (3)
src/lib/vram-calculator.ts:122
- Consider adding unit tests for calculateKVCache to cover scenarios with different effective batch sizes based on VLLM_CONFIG.ACTIVE_USER_RATIO and MEMORY_POOL_OVERHEAD.
function calculateKVCache(
src/lib/vram-calculator.ts:136
- [nitpick] The variable name cachePerToken is somewhat generic; consider renaming it to kvCachePerToken to clarify that it refers to KV cache byte size per token.
const cachePerToken =
src/pages/vram-calculator/VramCalculatorPage.tsx:557
- Since the CPU resources section has been removed, consider cleaning up related translation keys (e.g., pages.vramCalculator.sections.cpuResources) to avoid unused localization entries.
<div className="border border-border rounded-lg p-6">
Comment on lines
201
to
207
| if (availableVramPerGpu >= 80) { | ||
| baseOverhead = 2.0; | ||
| baseOverhead = 2.0; // H100, A100 80GB | ||
| } else if (availableVramPerGpu >= 40) { | ||
| baseOverhead = 1.5; | ||
| baseOverhead = 1.5; // A100 40GB, A6000 | ||
| } else if (availableVramPerGpu >= 24) { | ||
| baseOverhead = 1.2; | ||
| baseOverhead = 1.2; // RTX 4090, RTX 3090 | ||
| } else if (availableVramPerGpu >= 16) { |
There was a problem hiding this comment.
[nitpick] Consider extracting the GPU memory tier thresholds (80, 40, 24, 16) into a configuration object or enum to improve maintainability and avoid magic numbers.
samuel032khoury
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check the internal design doc.