fix the comment for CODEC_GUID_JPEG#28
Conversation
| #define CODEC_GUID_NSCODEC "\xb9\x1b\x8d\xca\x0f\x00\x4f\x15\x58\x9f\xae\x2d\x1a\x87\xe2\xd6" | ||
|
|
||
| /* CODEC_GUID_JPEG 0x430C9EED1BAF4CE6869ACB8B37B66237*/ | ||
| /* CODEC_GUID_JPEG 0xE64CAF1BED9E0C43869ACB8B37B66237 */ |
There was a problem hiding this comment.
I think it should be 0x1BAF4CE69EED430C869ACB8B37B66237.
There was a problem hiding this comment.
See CODEC_GUID_REMOTEFX.
0x76772F12 BD72 4463 AF B3 B73C9C6F7886
\x12\x2F\x77\x76 \x72\xBD \x63\x44 \xAF \xB3 \xB7\x3C\x9C\x6F\x78\x86
So CODEC_GUID_JPEG should be:
0x1BAF4CE6 9EED 430C 86 9A CB8B37B66237
\xE6\x4C\xAF\x1B \xED\x9E \x0C\x43 \x86 \x9A \xCB\x8B\x37\xB6\x62\x37
There was a problem hiding this comment.
Oh, yea, your right. What is the format we want to use? I was assuming if there is no space for dash it was just a byte dump.
There was a problem hiding this comment.
Let's use the 8-4-4-4-12 textual representation in comment as we are using it in ms-rdpbcgr.h. I believe it is the most common textual representation for GUID/UUID.
https://github.com/neutrinolabs/xrdp/blob/devel/common/ms-rdpbcgr.h#L375-L401
Another format we use is byte dump, which actually appears in the protocol stream. It is required to compare by memcmp, that's the reason why we define the macro.
See also: https://devblogs.microsoft.com/oldnewthing/20220928-00/?p=107221
2 participants
No description provided.