Skip to content

refactor: replace Split in loops with more efficient SplitSeq #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pr0n00gler merged 1 commit into from
Feb 24, 2026
Merged

refactor: replace Split in loops with more efficient SplitSeq #1042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions utils/cli_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const (

func ParseUint64SliceFromString(s, separator string) ([]uint64, error) {
var parsedInts []uint64
for _, s := range strings.Split(s, separator) {
for s := range strings.SplitSeq(s, separator) {
s = strings.TrimSpace(s)

parsed, err := strconv.ParseUint(s, base, bitlen)
Expand All @@ -30,7 +30,7 @@ func ParseUint64SliceFromString(s, separator string) ([]uint64, error) {

func ParseSdkIntFromString(s, separator string) ([]math.Int, error) {
var parsedInts []math.Int
for _, weightStr := range strings.Split(s, separator) {
for weightStr := range strings.SplitSeq(s, separator) {
weightStr = strings.TrimSpace(weightStr)

parsed, err := strconv.ParseUint(weightStr, base, bitlen)
Expand All @@ -44,7 +44,7 @@ func ParseSdkIntFromString(s, separator string) ([]math.Int, error) {

func ParseSdkDecFromString(s, separator string) ([]math.LegacyDec, error) {
var parsedDec []math.LegacyDec
for _, weightStr := range strings.Split(s, separator) {
for weightStr := range strings.SplitSeq(s, separator) {
weightStr = strings.TrimSpace(weightStr)

parsed, err := math.LegacyNewDecFromStr(weightStr)
Expand Down
Loading