Feat: tf pull upstream #913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
swelf19
reviewed
May 19, 2025
x/tokenfactory/keeper/before_send.go
Outdated
| // consume gas used for calling contract to the parent ctx | ||
| c.GasMeter().ConsumeGas(childCtx.GasMeter().GasConsumed(), "track before send gas") | ||
| childCtx := c.WithGasMeter(storetypes.NewGasMeter(types.BeforeSendHookGasLimit)) | ||
| _, err = k.contractKeeper.Sudo(childCtx.WithEventManager(em), cwAddr, msgBz) |
Contributor
There was a problem hiding this comment.
-
In the line above, you're creating a new context with a gas manager, and then again, line later, a new context with an event manager - maybe it's better to combine both
Withcalls into a single statement? -
What is the reason for creating a new event manager? We're essentially ignoring all events from sudo calls.
Collaborator
Author
There was a problem hiding this comment.
You are right, fixed that
Collaborator
Author
swelf19
approved these changes
Jun 3, 2025
NeverHappened
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls recent changes in the tokenfactory module from the Osmosis upstream and more specifically:
Task: https://hadronlabs.atlassian.net/jira/software/projects/NTRN/boards/3?selectedIssue=NTRN-518