Add UI element for Instrument Settings#141
Merged
glass-ships merged 20 commits intonextfrom Feb 13, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #141 +/- ##
==========================================
+ Coverage 63.60% 63.78% +0.17%
==========================================
Files 117 118 +1
Lines 9792 9882 +90
==========================================
+ Hits 6228 6303 +75
- Misses 3564 3579 +15 ☔ View full report in Codecov by Sentry. |
added 14 commits
January 30, 2025 14:31
13 tasks
mdoucet
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
Adds an
InstrumentSettingsmodel and UI interface for modifying intrument geometry parameters with which to run reduction.Additionally adds deprecation warning for
sf_calculatorCheck all that apply:
Added integration testsReferences:
Manual test for the reviewer
(instructions to set up the environment)
Clone the
instrument-settingsbranch of lr_reduction:Activate your RefRed conda environment, replace the existing lr_reduction installation with the local version:
Start RefRed GUI
Then load
test/data/test_instrument_settings.xml(make sure/SNSis mounted via fusermount) and attempt to run reduction,Or run tests
(refred)> pytest test/unit/RefRed/test_main.pyCheck list for the reviewer