Add ability to add non-"Direct Beam" PV-labeled runs to the Direct Beam table - #229
Closed
darshdinger wants to merge 20 commits into
Closed
darshdinger wants to merge 20 commits into
darshdinger wants to merge 20 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #229 +/- ##
==========================================
- Coverage 65.72% 65.57% -0.15%
==========================================
Files 37 37
Lines 6909 6914 +5
==========================================
- Hits 4541 4534 -7
- Misses 2368 2380 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ive data during table population
backmari
reviewed
Nov 25, 2025
This was referenced Dec 4, 2025
darshdinger
deleted the
ewm11847-add-ability-to-load-non-Direct_beam-labeled-pv-data
branch
January 8, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
Allow users to add any run to the Direct Beam table even if the EPICS PV
data_typeis not set to indicate a direct beam (data_type != 1). This enables calibration and other runs started with EPICS "Start RUN" (which may not set the Direct Beam PV-tag) to be used as normalization runs.Key changes:
DataManager.add_active_to_direct_beam_list()now accepts any run and returns an integer status:2— added and is a true direct beam (data_type == 1)1— added but not labeled as a direct beam (data_type != 1); logs a warning0— not added (already present)MainHandler.add_direct_beam()updated to show a non-blocking warning message when a non-direct-beam run is added (keeps blocking error for duplicates).is_direct_beammetadata unchanged to preserve original metadata integrity and avoid altering run semantics.PlotManager.plot_reflectivity_or_intensity()updated to check if active data is in the direct beam list (in addition to checkingis_direct_beamattribute) to correctly display "Intensity" plots for non-direct-beam runs added to the direct beam table.@pytest.mark.datarepo)Check all that apply:
References:
(Quick steps to exercise the feature locally; CI may need the data repo for full integration tests.)
(instructions to set up the environment)
Check list for the reviewer