fix: use lowercase for country flag SVG filenames #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The country flag images were not loading on Linux due to case sensitivity. The Angular components used toUpperCase() to build the image path, but most SVG files were lowercase (e.g., us.svg, fr.svg). Changes: - Use toLowerCase() instead of toUpperCase() in flag-ip-fqdn component - Use toLowerCase() instead of toUpperCase() in exposure-service-pod-report-grid - Rename 9 uppercase SVG files to lowercase for consistency: AC.svg, BQ-BO.svg, BQ-SA.svg, BQ-SE.svg, IC.svg, TA.svg, XA.svg, XC.svg, XO.svg
Collaborator
|
Hi @gigi206 , Thank you for your PR. The new country flag picture names are uppercase. But when we replace the picture files, Github is not case sensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Country flag images were not loading on Linux systems due to filesystem case sensitivity. The Angular components used
toUpperCase()to build the image path (e.g.,/assets/img/country-flag/US.svg), but most SVG files were stored in lowercase (e.g.,us.svg).This resulted in the error:
Request is missing required HTTP header 'Token'because the static resource was not found, causing the rejection handler to return the API's missing token error instead.Changes
toLowerCase()instead oftoUpperCase()inflag-ip-fqdncomponenttoLowerCase()instead oftoUpperCase()inexposure-service-pod-report-gridcomponentAC.svg→ac.svgBQ-BO.svg→bq-bo.svgBQ-SA.svg→bq-sa.svgBQ-SE.svg→bq-se.svgIC.svg→ic.svgTA.svg→ta.svgXA.svg→xa.svgXC.svg→xc.svgXO.svg→xo.svg