Skip to content

NVSHAS-9748 [Helm] NV helm update for supporting name referral for common groups in CRD#472

Merged
venkateshjayagopal merged 1 commit intoneuvector:masterfrom
venkateshjayagopal:master
Mar 7, 2025
Merged

NVSHAS-9748 [Helm] NV helm update for supporting name referral for common groups in CRD#472
venkateshjayagopal merged 1 commit intoneuvector:masterfrom
venkateshjayagopal:master

Conversation

@venkateshjayagopal
Copy link
Contributor

@venkateshjayagopal venkateshjayagopal commented Mar 6, 2025

Add helm chart support for referral for common groups in CRD on core and crd chart.
Files changed in core chart,

  • crd.yaml
  • crd-role.yaml
  • crd-role-least.yaml
  • clusterrole.yaml

File changed in crd chart,

  • crd.yaml

Files changed in unit-test for new resource addition,

  • crd_test.go
  • role_test.go

…mmon groups in CRD

Adding nvgroupdefinitions.neuvector.com in crd chart

Fixing API groups

Changing unit test for new resource addition
@venkateshjayagopal
Copy link
Contributor Author

venkateshjayagopal commented Mar 7, 2025

Tested below combinations

  • 5.4.3-rc1 using Native K8s.
  • 5.4.3-rc1 using Native K8s + leastprivilege
  • 5.4.3-rc1 using Openshift v4.14

@venkateshjayagopal venkateshjayagopal marked this pull request as ready for review March 7, 2025 21:08
@venkateshjayagopal venkateshjayagopal requested review from a team and yasker as code owners March 7, 2025 21:08
Copy link
Contributor

@holyspectral holyspectral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@venkateshjayagopal venkateshjayagopal merged commit 58e0e70 into neuvector:master Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants